Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abortTimelineByName() to allow ending specific timelines #3168

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Add abortTimelineByName() to allow ending specific timelines #3168

merged 3 commits into from
Nov 9, 2023

Conversation

jodeleeuw
Copy link
Member

@jodeleeuw jodeleeuw commented Oct 30, 2023 •
edited
Loading

This is to implement #616

Allows for jsPsych.abortTimelineByName('name'). name is added as an optional property of timelines.

Todo:

  • Add documentation updates

@jodeleeuw jodeleeuw added this to the 8.0 milestone Oct 30, 2023
@jodeleeuw jodeleeuw requested a review from bjoluc October 30, 2023 17:04
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: a4c573e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
jspsych Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jodeleeuw jodeleeuw linked an issue Oct 30, 2023 that may be closed by this pull request
Allow programmatic end of a specific timeline, identified by ID #616
Closed
@bjoluc
Copy link
Member

bjoluc commented Nov 2, 2023

Great to see you working on new v8 features ☺️ I'm on a vacation until the middle of next week and coming back to this/jsPsych afterwards. I like the idea of naming timelines (I think we were thinking about using object references for this once?), looks very elegant to me!

bjoluc
bjoluc reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@bjoluc bjoluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I hope you're not having too much trouble finding your way around the new core. Maybe rename getTimelineByName => getActiveTimelineByName?

@jodeleeuw jodeleeuw merged commit 72ddfa0 into v8 Nov 9, 2023
2 checks passed
@jadeddelta jadeddelta deleted the abort-timeline-by-id branch December 25, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoluc bjoluc bjoluc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

Allow programmatic end of a specific timeline, identified by ID
2 participants
@jodeleeuw @bjoluc