force dom to clear after each individual test case #3435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR clears the dom after every individual test. the expected pattern of using
startTimeline
in thetest-utils
package is to deconstruct the tuple given and take outdisplayElement
in order to directly query the experiment's display element. however, some plugins still querydocument
directly, which isn't optimal as the dom is not cleared, meaning there are multiple jsPsych display elements on the dom at a given time. this results in some interesting edge cases where the wrong button is queried, or one test failing means every next test that interacts with thedocument
fails.this is a small, simple update in order to allow tests to both query
document
anddisplayElement
without having to deal with this behavior by making sure the DOM is wiped before each individual test.