fix: Add --install-python=false
to install invocation.
#85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The installer may attempt to install a Python package on MacOS, if the versions do not line up with the minimum version blessed by the script. To do this, it attempts to run sudo.
This disables the installation with an install flag.
Motivation and Context
Having a plugin modify global state (like installing a version of python globally) goes against the very reason for having an asdf plugin. Also, asdf installs should be non-interactive, and sudo requires user input.
This causes the minimum supported version to be 352.0.0 or greater (as the first version with this flag).
Alternatives to remove backwards compatibility issues with the change:
Fixes #82.
Types of changes
How Has This Been Tested?
--install-python=false
.Checklist: