Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(switch): layer in bool expr #1060

Merged
merged 4 commits into from
May 25, 2024
Merged

feat(switch): layer in bool expr #1060

merged 4 commits into from
May 25, 2024

Conversation

jtroo
Copy link
Owner

@jtroo jtroo commented May 22, 2024

Describe your changes. Use imperative present tense.

Closes #1026

Checklist

  • Add documentation to docs/config.adoc
    • Yes
  • Add example and basic docs to cfg_samples/kanata.kbd
    • Yes
  • Update error messages
    • Yes
  • Added tests, or did manual testing
    • Yes

@jtroo
Copy link
Owner Author

jtroo commented May 22, 2024

@oblitzitate can you see if this PR implements the feature as intended?

Example syntax from test file:

(defcfg)
(defsrc a b)
(defalias b (switch
    ((layer base)) x break
    ((layer other)) y break))
(deflayer base (layer-while-held other) @b)
(deflayer other XX @b)

@oblitzitate
Copy link

oblitzitate commented May 23, 2024

I pretty much applied it similarly to the solution I mentioned in the feature request and it seems to work as intended. Thanks!

@jtroo jtroo merged commit c1001bb into main May 25, 2024
4 checks passed
@jtroo jtroo deleted the switc-layer branch May 25, 2024 22:21
eugenesvk pushed a commit to eugenesvk/kanata that referenced this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Allow to check current layer for switch-cases
2 participants