Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unmod): accept optional mod list as first param #1103

Merged
merged 11 commits into from
Jun 11, 2024
Merged

feat(unmod): accept optional mod list as first param #1103

merged 11 commits into from
Jun 11, 2024

Conversation

jtroo
Copy link
Owner

@jtroo jtroo commented Jun 10, 2024

Describe your changes. Use imperative present tense.

Add backwards-compatible change to accept an optional list as the first parameter of unmod to specify a specific set of modifiers to temporarily release.

This also includes:

  • fix for a test consistency issue on Windows related to the state kept for the numlock shift workaround
  • removal of the numlock shift workaround for scancode output because it does not need the code, and the workaround is strictly a downgrade in functionality

Checklist

  • Add documentation to docs/config.adoc
    • Yes or N/A
  • Add example and basic docs to cfg_samples/kanata.kbd
    • Yes or N/A
  • Update error messages
    • Yes or N/A
  • Added tests, or did manual testing
    • Yes

parser/src/cfg/mod.rs Outdated Show resolved Hide resolved
src/tests.rs Outdated Show resolved Hide resolved
src/kanata/mod.rs Outdated Show resolved Hide resolved
@jtroo jtroo merged commit ff71860 into main Jun 11, 2024
4 checks passed
@jtroo jtroo deleted the unmod branch June 11, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant