Websocket derp test fixes #2247
Conversation
…ailscale head integration testing: comply with linter
…s for tailscale head integration testing: tsic.New must never return nil
… options for tailscale head
enoperm
requested review from
ohdearaugustin,
nblock,
juanfont and
kradalby
as code owners
integration/embedded_derp_test.go
Outdated
| err = s.CreateTailscaleIsolatedNodesInUser( | ||
| hash, | ||
| userName, | ||
| "all", | ||
| "head", |
There was a problem hiding this comment.
This can be the VersionHead constant you added
There was a problem hiding this comment.
Good idea, I probably missed this instance because I only looked at the linter output when I introduced that constant.
| // This option is only meaningful when invoked on **HEAD** versions of the client. | ||
| // Attempts to use it with any other version is a bug in the calling code. | ||
| func WithBuildTag(tag string) Option { | ||
| return func(tsic *TailscaleInContainer) { |
There was a problem hiding this comment.
I propose panicking here if the tsic passed is not HEAD, just to fail fast so the dev can fix it without faffing around.
There was a problem hiding this comment.
Done, for now I have opted to panic with the same error value I return from the other checks.
At this point I think it might be safe to remove the build tags check here, but since I wrote it to be generic and check for any build time config, it may still catch mistakes on future build options. I am not against removing it if desired, though.
|
Thanks! |
Fixes #2241