Add startup probe to juice-shop pod #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J12934
requested changes
Oct 27, 2023
There was a problem hiding this comment.
Hi 👋
Ah yes good point / idea.
I'd like to tweak the numbers a bit to these one.
With this change the minimal startup time would otherwise increase from 5s -> 10s. Not a big deal but noticiable and not nearly as snappy.
With this change this might even make the start up even faster while still allowing it to start on slow machines.
Co-authored-by: Jannik Hollenbach <jannik@hollenbach.de>
J12934
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a startup probe with the same liveness checks to cover the worst case startup time. On slower nodes the container does not come up if it takes too long to during startup.