Skip to content

Commit

Permalink
Merge pull request #37 from jukylin/fix_sp_error
Browse files Browse the repository at this point in the history
fix issues 35
  • Loading branch information
jky-yy authored Apr 26, 2019
2 parents 8a4a7b5 + 124eb31 commit f238a99
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion example/HTTP.php
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
$clientTrace->inject($clientSpan2->spanContext, Formats\TEXT_MAP, $injectTarget2);

$method = 'GET';
$url = 'https://github.com/search?utf8=✓&q=jaeger-php';
$url = 'https://github.com/search?q=jaeger-php';
$client = new Client();
$res = $client->request($method, $url, ['headers' => $injectTarget2]);

Expand Down
5 changes: 1 addition & 4 deletions src/Jaeger/Span.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@

namespace Jaeger;

use OpenTracing\SpanContext;
use OpenTracing\Reference;
use Jaeger\Thrift\SpanRefType;

class Span implements \OpenTracing\Span{

Expand All @@ -26,7 +23,7 @@ class Span implements \OpenTracing\Span{

public $references = [];

public function __construct($operationName, SpanContext $spanContext, $references){
public function __construct($operationName, \OpenTracing\SpanContext $spanContext, $references){
$this->operationName = $operationName;
$this->startTime = $this->microtimeToInt();
$this->spanContext = $spanContext;
Expand Down

0 comments on commit f238a99

Please sign in to comment.