fix: add exception when generated thrift string exceeds maximum allowed package siz #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do you Got the error, I already check the size before send |
|
Yes, I saw that. Is the test I wrote sufficient to explain the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when experimenting with very large traces, I encountered errors related to
socket_sendto, which is fine:However, there is a small window from 65000 bytes to 65507 bytes, where packages are created and sent by this library, but discarded of Jaeger, because not the complete thrift payload fit into one package.
This PR adds an exception to cover those edge cases and a test for
AgentClient. Feel free to ask questions and provide feedback for improvements. :)