Update play-json dependency to 3.x, update README. Fixes #91 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
approved these changes
Nov 9, 2023
|
Thank you for the quick PR! You will also have to reset the compatibility intention to play-json-derived-codecs/build.sbt Line 10 in 214b5a1 And it seems we need to update our Scala.js dependency as well because play-json is using a very recent version of Scala.js. |
|
Hello. Any chance to see this merged? |
|
@julienrf any chance of merging this in the nearest future? |
|
Hello! Thank you for your interest. Can someone fix the CI failure according to the explanation at #92 (comment)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for play-json 3.0 with the new groupId on the dependency.
Fixes #91