Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run automated code cleanup #32

Merged
merged 5 commits into from
Nov 25, 2023
Merged

Run automated code cleanup #32

merged 5 commits into from
Nov 25, 2023

Conversation

dimhotepus
Copy link
Contributor

  • Format sources.
  • Remove unused usings.
  • Drop unneeded casts.
  • Inline out vars.
  • Use compound assignments.
  • new() / default.
  • Add access modifiers.
  • Use readonly.
  • Use pattern matching.
  • Simplify boolean expressions.

Also use correct naming in async / sync test runs.

juliusfriedman
juliusfriedman reviewed Nov 25, 2023
View reviewed changes
Copy link
Owner

@juliusfriedman juliusfriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes!

Mostly looks good to me, I will finish up the review ASAP.

Thanks again for your contributions!

@dimhotepus
Copy link
Contributor Author

Lots of changes!

Mostly looks good to me, I will finish up the review ASAP.

Thanks again for your contributions!

Those changes (except last one) are created by Microsoft Visual Studio automatic code cleanup profiles.

juliusfriedman
juliusfriedman approved these changes Nov 25, 2023
View reviewed changes
Copy link
Owner

@juliusfriedman juliusfriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything went well including the testing, Thanks again for your contributions!

@juliusfriedman juliusfriedman merged commit 7582c40 into juliusfriedman:master Nov 25, 2023
3 checks passed
@dimhotepus dimhotepus deleted the automated-code-cleanup branch November 26, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusfriedman juliusfriedman juliusfriedman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimhotepus @juliusfriedman