Support dot imports #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@julz looks like the jobs may require a bump to 1.19 and 1.20 from 1.15 and 1.16? Would you have a problme with that? |
|
not at all, that would be great! |
|
Done: #17 |
Signed-off-by: Roman Mohr <rmohr@google.com>
Typically no dot imports are desired but ginkgo/gomega is a common exception. Signed-off-by: Roman Mohr <rmohr@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind bug
Fix suggested fixes for
.imports.Before this change, a dot import literally replaced the import name. For instancel
pkgname.Functionwas transformed to..Functioninstead of justFunction.While it is in general not desirable to use dot imports in golang, there are prominent exceptions, specifically ginkgo/gomega, where some may still want to use dot imports.
Release Note