-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up signatures #415
Fix up signatures #415
Conversation
@DeepDiver1975 Can we please get this merged and released? This issue prevents me from updating production code to 1.x |
Generally speaking I'd prefer to have dedicated pull requests for dedicated topics/issues. THX a lot |
The hard dependency on phpunit causes issues to run ci on php 7.x .... please remove. |
I'll roll back all but my own changes here. |
2922ad4
to
dd299ba
Compare
Also add phpunit dependency, add test target, and fix up phpunit.xml.dist.
fwiw, phpunit dep worked for me on php 7.4 just now but I've removed it as requested. |
Given the failures on php 7.0, the options are dropping support 7.0 (my preference, since it is EOL) or dropping the type hints. |
php7.0 compliant version #427 |
Also add phpunit dependency, add test target, fix up phpunit.xml.dist, and add changelog entry.
Fixes #412