Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanups in DenseAxisArray #3429

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Minor cleanups in DenseAxisArray #3429

merged 1 commit into from
Jul 7, 2023

Conversation

blegat
Copy link
Member

@blegat blegat commented Jul 5, 2023

The comments says it's defined on Julia v0.7 and I can verify that it's defined in Julia v1.6 at least which is the minimal Julia version we care about.

julia> VERSION
v"1.6.7"

julia> Base.print_array
print_array (generic function with 4 methods)

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 83.33% and no project coverage change.

Comparison is base (1bb7b8f) 97.97% compared to head (2698bc1) 97.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3429   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files          34       34           
  Lines        4979     4979           
=======================================
  Hits         4878     4878           
  Misses        101      101           
Impacted Files Coverage Δ
src/Containers/DenseAxisArray.jl 96.48% <83.33%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow odow merged commit 736e49e into master Jul 7, 2023
10 of 11 checks passed
@odow odow deleted the bl/dense_minor branch July 7, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants