Add an operate method for abs (#243)

jump-dev · Nov 27, 2023 · 4cc20ad · 4cc20ad
1 parent ac7a8a9
commit 4cc20ad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/interface.jl b/src/interface.jl
@@ -190,6 +190,10 @@ function operate end
 # custom `operate` method.
 operate(::typeof(-), x) = -x
 
+# This is not efficient, as it may make unnecessary intermediate copies,
+# but seems like the best way to write a generic implementation.
+operate(::typeof(abs), x) = abs(copy_if_mutable(x))
+
 function operate(
  op::Union{
  typeof(+),

diff --git a/test/interface.jl b/test/interface.jl
@@ -97,7 +97,7 @@ end
 @testset "operate" begin
  @testset "$T" for T in (Int, BigInt, Rational{Int})
  x = T(7)
- @testset "1-ary $op" for op in [+, *, gcd, lcm]
+ @testset "1-ary $op" for op in [+, *, gcd, lcm, abs]
  a = op(x)
  b = MA.operate(op, x)
  @test a == b