dispatch.jl: simplify overloads for SparseMatrix * AbstractArray

[odow]

Part of #178

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (352aa8f) 86.14% compared to head (fe5e4a1) 89.90%.
Report is 32 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   86.14%   89.90%   +3.76%     
==========================================
  Files          20       23       +3     
  Lines        1877     2547     +670     
==========================================
+ Hits         1617     2290     +673     
+ Misses        260      257       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blegat]

Is this adding more methods that what was done previously ?

[odow]

There are a few more, because it includes things like *(::Adjoint, ::Transpose). I don't really understand how we picked the current set of methods. It feels somewhat arbitrary.

[blegat]

I don't really understand how we picked the current set of methods. It feels somewhat arbitrary.

Trials and errors, I tried to have as few as possible but I had to add some when tests where failing.
The approach of this PR is better unless it starts adding so many methods that the compiler starts being slow or have issues.
In the long term, we should improve LinearAlgebra/SparseArrays to make this easier.

[odow]

Merging because this is a small win. I don't think we need to add all the LinearAlgebra method just yet though.