Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rewrite of +(x, *(y...)) into add_mul #225

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Sep 1, 2023

Closes #224

TODO

  • Tests

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (e3f1da6) 89.51% compared to head (6cc2f52) 89.57%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   89.51%   89.57%   +0.05%     
==========================================
  Files          23       23              
  Lines        2137     2149      +12     
==========================================
+ Hits         1913     1925      +12     
  Misses        224      224              
Files Changed Coverage Δ
src/rewrite_generic.jl 99.37% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow mentioned this pull request Sep 5, 2023
25 tasks
@odow
Copy link
Member Author

odow commented Sep 5, 2023

So the JuMP master tests are failing because this hits some different methods.

In particular, we now hit:

add_mul(a, b, c) = muladd(b, c, a)

which rewrites a + b * c as b * c + a!!!! How annoying.

@odow
Copy link
Member Author

odow commented Sep 6, 2023

Okay, this is now good to merge.

@blegat blegat merged commit 774bc08 into master Sep 6, 2023
11 checks passed
@odow odow deleted the od/fix-add-mul-rewrite branch November 29, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

potential performance issue without move_factors_into_sums
2 participants