Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add corresponding operate_to! method for Matrix-scalar product #273

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

blegat
Copy link
Member

@blegat blegat commented Apr 5, 2024

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 91.75%. Comparing base (69b1c51) to head (7f10e04).
Report is 3 commits behind head on master.

❗ Current head 7f10e04 differs from pull request most recent head 7c5ce30. Consider uploading reports for the commit 7c5ce30 to get more accurate results

Files Patch % Lines
src/implementations/LinearAlgebra.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   91.92%   91.75%   -0.17%     
==========================================
  Files          23       23              
  Lines        2216     2220       +4     
==========================================
  Hits         2037     2037              
- Misses        179      183       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blegat blegat changed the title Allow sum of arrays and product with scalar Add corresponding operate_to! method for Matrix-scalar product Apr 16, 2024
@blegat
Copy link
Member Author

blegat commented Apr 16, 2024

Ready for review, I'll merge in a few days if there is no objection

@odow odow merged commit 6f0e699 into master Apr 17, 2024
9 checks passed
@odow odow deleted the bl/array_sum branch April 17, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants