Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow NONE color #3359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

blockchainian
Copy link

@blockchainian blockchainian commented Jul 9, 2023

this pr makes fzf gutter work for default background color NONE:

let g:fzf_colors = {
\   'gutter':  ['bg', 'Conceal']
\}

highlight Conceal ctermbg=NONE
  • before
image
  • after
image

@blockchainian blockchainian changed the title fix NONE color allow NONE color Jul 9, 2023
@junegunn
Copy link
Owner

Thanks, but this is not compatible with the current model where you can specify multiple highlight groups.

let g:fzf_colors = {
\   'gutter':  ['bg', 'Conceal', 'Normal', 'Comment']
\}

highlight Normal ctermbg=233
highlight Conceal ctermbg=NONE

['bg', 'Conceal', 'Normal', 'Comment'] translates to "Use the background color of the first highlight group that has a background color", and that is 233 of Normal. But with your patch, it will choose -1 for Conceal, ignoring the rest of the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants