-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context aware completion for ssh command #3424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems that new logic broke the tests. I'll try to fix it. |
rebrendov
changed the title
Context aware completion for ssh command
WIP: Context aware completion for ssh command
Sep 4, 2023
rebrendov
changed the title
WIP: Context aware completion for ssh command
Context aware completion for ssh command
Sep 4, 2023
rebrendov
changed the title
Context aware completion for ssh command
WIP: Context aware completion for ssh command
Sep 4, 2023
rebrendov
changed the title
WIP: Context aware completion for ssh command
Context aware completion for ssh command
Sep 4, 2023
Ok, made sure |
junegunn
reviewed
Sep 5, 2023
I tried to simplify the code and make both implementations as similar as possible.
Let me know what you think. |
Merged with a test case. Thanks. |
Sorry, I forgot to send a comment. The simplified code looks great. Thank you for the useful tool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #3416.
Changes for zsh were tested on ArchLinux machine and changes for bash were tested on ArchLinux and Ubuntu Server machines.
For bash had to copy-paste
_fzf_complete
call from_fzf_host_completion
to_fzf_ssh_completion
to make sure that_fzf_ssh_completion_post
is called.