-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --builtin-filter-dirs #3464
Conversation
* fzf's builtin filesystem walker is faster then overridding via FZF_DEFAULT_COMMAND, especially on Windows * If this switch is specified, fzf will read directories instead of files if FZF_DEFAULT_COMMAND is not specified and there's no input from tty
Thanks, but I would rather not add options for file system traversal, because that is not really the responsibility of fzf. Is it really not possible to find a performant external command on Windows? |
I'm open to ideas, but using |
I agree that design-wise it makes sense, but pragmatically it's just faster to walk the filesystem in native Go. |
Thanks. Is the performance difference due to the performance limit of |
Closed in #3649. |
FZF_DEFAULT_COMMAND
, especially on WindowsFZF_DEFAULT_COMMAND
is not specified and there's no input from tty