revisit after Oct 2027: drop support for ancient fish versions in interactiveness checks #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like with the other shells, exit fish to, if called from a non-interactive shell. We use an `if`-block and don’t just return immediately for now, as older versions of fish (namely < 3.4.0) did not support to use `return` in `.`-scripts (this was only added with fish commit 3359e5d2e9bcbf19d1652636c8e448a6889302ae). Just using `exit` instead of a `return` wouldn’t be a proper solution either, as it would exit the whole shell, when `shell/key-bindings.fish` was executed or sourced from a non-interactive shell. While this should of course never happen, the idea of the whole check is to handle the situation gracefully, which `exit` can thus not do. Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
junegunn
reviewed
Oct 12, 2023
|
Closing this a as proper solution found above and implemented via #3467. |
calestyo
deleted the
drop-support-for-ancient-fish-versions-in-interactiveness-checks
branch
This improves commit 5cb5bbd by just returning from the script in case it’s sourced from a non-interactive shell, rather then using an `if`-block to not execute any further code (which is error prone, in case code gets accidentally added outside the `if`, and also less readable). This removes support for fish versions < 3.4.0, which should now no longer be used. Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves commit 5cb5bbd by just returning
from the script in case it’s sourced from a non-interactive shell, rather then
using an
if-block to not execute any further code (which is error prone, incase code gets accidentally added outside the
if, and also less readable).This removes support for fish versions < 3.4.0, which should now no longer be
used.