Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zsh): transform in CTRL_R #3557

Merged
merged 6 commits into from
Jan 5, 2024
Merged

fix(zsh): transform in CTRL_R #3557

merged 6 commits into from
Jan 5, 2024

Conversation

danztran
Copy link
Contributor

@danztran danztran commented Jan 1, 2024

fix #3556

@danztran
Copy link
Contributor Author

danztran commented Jan 2, 2024

The CI failed because the test miss a trailing space. However, the test runs normally on my machine. Is it ok to modify the test?

@junegunn
Copy link
Owner

junegunn commented Jan 3, 2024

The CI failed because the test miss a trailing space. However, the test runs normally on my machine. Is it ok to modify the test?

Strange. I can't reproduce the error either. Let me look into it.

@junegunn
Copy link
Owner

junegunn commented Jan 3, 2024

I can reproduce the error on the Ubuntu docker container which GitHub actions uses.

diff --git a/Dockerfile b/Dockerfile
index 308016f..aba5f22 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,5 +1,5 @@
-FROM --platform=linux/amd64 archlinux
-RUN pacman -Sy && pacman --noconfirm -S awk git tmux zsh fish ruby procps go make gcc
+FROM --platform=linux/amd64 ubuntu:22.04
+RUN apt-get update -y && apt install -y git make golang zsh fish ruby tmux
 RUN gem install --no-document -v 5.14.2 minitest
 RUN echo '. /usr/share/bash-completion/completions/git' >> ~/.bashrc
 RUN echo '. ~/.bashrc' >> ~/.bash_profile
@@ -8,4 +8,5 @@ RUN echo '. ~/.bashrc' >> ~/.bash_profile
 RUN rm -f /etc/bash.bashrc
 COPY . /fzf
 RUN cd /fzf && make install && ./install --all
+ENV LANG C.UTF-8
 CMD tmux new 'set -o pipefail; ruby /fzf/test/test_go.rb | tee out && touch ok' && cat out && [ -e ok ]
  1) Failure:
TestZsh#test_ctrl_r [/fzf/test/test_go.rb:3188]:
Expected: "echo 3rd"
  Actual: " echo 3rd"

But this is a non-issue if we're not going to use the LBUFFER approach.

shell/key-bindings.zsh Outdated Show resolved Hide resolved
shell/key-bindings.zsh Outdated Show resolved Hide resolved
shell/key-bindings.zsh Outdated Show resolved Hide resolved
@junegunn junegunn merged commit 2671259 into junegunn:master Jan 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zsh: transform does not work with CTRL+R
2 participants