Add keybindings for CTRL, ALT, SHIFT + UP, DOWN, RIGHT, LEFT, HOME, END, BACKSPACE, DELETE & more #3996
+1,009
−105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements some missing key bindings.
In particular all possible combinations of
CTRL
ALT
SHIFT
ALT+SHIFT
CTRL+ALT
CTRL+SHIFT
CTRL+ALT+SHIFT
in conjunction with
Up
,Down
,Left
,Right
,Home
,End
,Backspace
,Delete
,PageUp
,PageDown
.I added tests to the
LightRenderer
beforehand to make sure I wasn't breaking anything, and expanded them when I added new key bindings.So you can actually do stuff like:
This PR fixes #1747.