🧊 Don't replace node.data, append-new/override individual fields (#…

…1194)
jupyter-book · May 9, 2024 · 7c6f45c · 7c6f45c
1 parent 4661c47
commit 7c6f45c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/shaggy-apes-juggle.md b/.changeset/shaggy-apes-juggle.md
@@ -0,0 +1,5 @@
+---
+'myst-transforms': patch
+---
+
+Enable existing `node.data` to flow through transforms, allowing upstream user data to be preserved and available in the AST.
diff --git a/packages/myst-transforms/src/links/doi.ts b/packages/myst-transforms/src/links/doi.ts
@@ -30,7 +30,7 @@ export class DOITransformer implements LinkTransformer {
       return false;
     }
     link.url = doiUrl;
-    link.data = { doi: doi.normalize(doiUrl) };
+    link.data = { ...link.data, doi: doi.normalize(doiUrl) };
     link.internal = false;
     updateLinkTextIfEmpty(link, '');
     return true;

diff --git a/packages/myst-transforms/src/links/github.ts b/packages/myst-transforms/src/links/github.ts
@@ -113,7 +113,7 @@ export class GithubTransformer implements LinkTransformer {
       return false;
     }
     const [defaultText, data] = parsed;
-    link.data = data;
+    link.data = { ...link.data, ...data };
     link.internal = false;
     updateLinkTextIfEmpty(link, defaultText);
     return true;

diff --git a/packages/myst-transforms/src/links/rrid.ts b/packages/myst-transforms/src/links/rrid.ts
@@ -42,7 +42,7 @@ export class RRIDTransformer implements LinkTransformer {
       return false;
     }
     link.url = `${RESOLVER}${rrid}`;
-    link.data = { rrid };
+    link.data = { ...link.data, rrid };
     link.internal = false;
     updateLinkTextIfEmpty(link, rrid);
     return true;

diff --git a/packages/myst-transforms/src/links/wiki.ts b/packages/myst-transforms/src/links/wiki.ts
@@ -86,6 +86,7 @@ export class WikiTransformer implements LinkTransformer {
       .replace(/(?:^_)|(?:_$)/g, '');
     link.url = `${result.wiki}wiki/${page}`;
     link.data = {
+      ...link.data,
       page: page,
       wiki: result.wiki,
       lang: result.lang,