Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎆 Add webp --> png conversion for typst/pdf/word #1598

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Oct 22, 2024

No description provided.

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 7e07925

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
myst-cli Patch
mystmd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

function magickCommandAvailable() {
return which.sync('magick', { nothrow: true });
function magickCommandAvailable(): boolean {
return !!which.sync('magick', { nothrow: true });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better...!

@@ -353,6 +370,9 @@ const conversionFnLookup: Record<string, Record<string, ConversionFn>> = {
[ImageExtensions.gif]: {
[ImageExtensions.png]: gifToPng,
},
[ImageExtensions.webp]: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, cool - looks like the work to make these conversions somewhat declarative payed off for this one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@rowanc1 rowanc1 merged commit 02a8c3a into main Oct 22, 2024
7 checks passed
@rowanc1 rowanc1 deleted the feat/webp-png branch October 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants