Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reporting guidelines. #763

Merged
merged 7 commits into from
May 26, 2024
Merged

Update reporting guidelines. #763

merged 7 commits into from
May 26, 2024

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented May 24, 2024

Now that Public GHSA opening is available on most repo, be clearer that those can be used directly.

Now that Public GHSA opening is available on most repo, be clearer that
those can be used directly.
security.md Outdated Show resolved Hide resolved
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggestion, but giving a green light to allow you to merge later

security.md Outdated Show resolved Hide resolved
Carreau and others added 2 commits May 24, 2024 02:32
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@Carreau
Copy link
Member Author

Carreau commented May 24, 2024

Failures seem to be 429 too many requests as we check to many https://github.com/<user>, though the error message show a single / in https:/github... I'll try to add a ignore pattern.

@krassowski
Copy link
Member

In JupyterLab we have https://github.com/[^/]+/?$ ignore pattern https://github.com/jupyterlab/jupyterlab/blob/main/.github/workflows/linuxtests.yml#L155

@krassowski
Copy link
Member

krassowski commented May 24, 2024

But maybe it should be changed on maintainer-tools level after all, edit - it looks jupyterlab/maintainer-tools#226 already has it

@Carreau
Copy link
Member Author

Carreau commented May 24, 2024

meh, I guess we can just force-merge. I'm not sure why it still fails.

@krassowski krassowski linked an issue May 26, 2024 that may be closed by this pull request
@krassowski
Copy link
Member

All green, merging!

@krassowski krassowski merged commit 847b100 into jupyter:main May 26, 2024
5 checks passed
@Carreau
Copy link
Member Author

Carreau commented May 27, 2024

Thanks !

@Carreau Carreau deleted the can-use-ghs branch May 27, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check links is failing
3 participants