Skip to content

Commit

Permalink
fix traitlets warning->error on 6.5.x (#7051)
Browse files Browse the repository at this point in the history
* typo in default contents manager class

it's jupyter_server.services.contents, not jupyter_server.contents.services

* fix import of warnings.warn

never part of the traitlets API
  • Loading branch information
minrk authored Sep 19, 2023
1 parent 3797497 commit 566860b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion notebook/notebookapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -1408,7 +1408,7 @@ def _update_mathjax_config(self, change):
# and allow jupyter_server contents managers to pass
# through. If jupyter_server is not installed, this class
# will be ignored.
'jupyter_server.contents.services.managers.ContentsManager'
"jupyter_server.services.contents.managers.ContentsManager",
],
config=True,
help=_('The notebook manager class to use.')
Expand Down
3 changes: 2 additions & 1 deletion notebook/traittypes.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import inspect
from traitlets import ClassBasedTraitType, Undefined, warn
from warnings import warn
from traitlets import ClassBasedTraitType, Undefined

# Traitlet's 5.x includes a set of utilities for building
# description strings for objects. Traitlets 5.x does not
Expand Down

0 comments on commit 566860b

Please sign in to comment.