Update Jupytext Notebook url path

[RRosio]

Fixes #6942
I believe this addresses the last point in the issue above, as when a Jupytext Notebook is opened it no longer adds the /edit route but rather /notebooks.

[github-actions]

👈 Launch a Binder on branch RRosio/notebook/jupytext_url

[parmentelat]

cool, thanks @RRosio to haven care of this, please let me know if/when this gets released so I can give it a try

[jtpio]

@parmentelat were you able to try this change with the built assets for this PR?

[jtpio]

Or maybe we can check if widgetName contains the string Notebook?

jupytext is a third-party extension and not officially supported, so not sure we should hardcode its special case here.

[parmentelat]

@jtpio

Hi; unfortunately no, I am mostly away from keyboard these days
plus, I am not completely comfortable testing unreleased code, as my fuzzy understanding of the build process sometimes leads me to wrong conclusions, and so I tend to stick to pip installs as much as I can
So, as much as I'd love to see the issue solved, I'm afraid I am not going to be able to help, at least not for the uncoming release of notebook if that's still the plan

[jtpio]

I tend to stick to pip installs as much as I can

Normally the built artifact (wheel) can be installed just like a released version with pip install. There wouldn't be any major differences between unreleased and released code if this PR gets merged and a new release is made right after.

Likely the most important part would be to make sure it is tested in an isolated virtual environment.

[parmentelat]

I made quick test

• start from a fresh conda env with python=3.11
• pip install the wheel that I found on this page https://github.com/jupyter/notebook/actions/runs/5478810915 and specifically after extracting the zip found under notebook-dist-1558
• pip installed the latest jupytext dev wheel (built locally)

however with this setup, on matter how I open a jupytext notebook, I still see the /edit/ url

[RRosio]

With the PR I observed that right-clicking Open with and selecting Jupytext Notebook opens the jupytext notebook with the /notebooks route rather than the /edit route. However when double-clicking the jupytext notebook indeed it goes on to open at the /edit route unlike the classic Notebook which after double-clicking opens a jupytext notebook under the /notebooks route.
Is this a matter of updating Notebook 7 so that the double-click behavior be what it was in classic Notebook?

[jtpio]

Is this a matter of updating Notebook 7 so that the double-click behavior be what it was in classic Notebook?

Normally double clicking should open the document with its default factory. Without configuration this seems to still be Editor for a Jupytext Notebook:

But testing with this PR and using the user settings provided by @parmentelat in #6914 (comment) to override the default factory, double clicking seems to be opening the file with /notebooks:

jupytext-default-factory-settings.mp4

[RRosio]

But testing with this PR and using the user settings provided by @parmentelat in #6914 (comment) to override the default factory, double clicking seems to be opening the file with /notebooks

Ah okay, I was missing the user settings. Once using those settings, I too witness that same behavior.

[jtpio]

Thanks @RRosio for looking into this issue!

The change looks good, and should already improve the case of Jupytext 👍