Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): add config cleanup on payment connector deletion #5998

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

noagbmn
Copy link
Contributor

@noagbmn noagbmn commented Sep 23, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fixes #5966 (in both v1 and v2). Now the router cleans up the configs table (or business_profile in v2) when a connector is deleted.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Added a payment and payout processor, checked if values are present in config, deleted and rechecked.
v1:
v1test

v2:
v2test

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@noagbmn noagbmn requested review from a team as code owners September 23, 2024 13:34
Copy link

semanticdiff-com bot commented Sep 23, 2024

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Filename Status
✔️ crates/router/src/core/admin.rs Analyzed
✔️ crates/common_enums/src/enums.rs Analyzed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Bug in merchant connector account create - delete flows
1 participant