ci(cypress): Add field level verification #6153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 4 of 4 files. Overall, the semantic diff is 19% smaller than the GitHub diff. 1 files do not contain logic changes.
|
Gnanasundari24
added
A-CI-CD
pixincreate
reviewed
Oct 3, 2024
likhinbopanna
previously approved these changes
Oct 3, 2024
pixincreate
reviewed
Oct 7, 2024
There was a problem hiding this comment.
nit:
if you don't mind, can the assertion changes be applied to all the assertions in this file?
There was a problem hiding this comment.
this can be taken up as a separate pr
There was a problem hiding this comment.
Since this is a significant change, I thought it would be better to go with a patch update rather than updating everything at once
likhinbopanna
approved these changes
Oct 7, 2024
pixincreate
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added assertions to validate individual field values in the CreatePayment, ConfirmPayment, and RetrievePayment flows for Stripe.
Motivation and Context
Verify individual field values in Cypress tests for enhanced accuracy
How did you test it?
Ran locally
Checklist
cargo +nightly fmt --allcargo clippy