-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix_health
: trusted_users
check
#62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the system_rs
crate going to be useful in general sense? Given that it contains only information needed for nix_health
, I'd think not. In that case, SysInfo
should be part of nix_rs
itself (presuming it provides information about the environment in which Nix is installed).
(Bear in mind that any local crate that nix_health
depends will have to be published to crates.io, since we publish nix_health
itself: https://crates.io/crates/nix_health)
crates/system_rs/Cargo.toml
Outdated
|
||
[dependencies] | ||
cfg-if.workspace = true | ||
os_info = "3.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this crate be used for #58 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will verify if that's possible.
I thought it could add on top of whatever |
Whether I am in rosetta or not, I get the following output from the OS information: Mac OS 13.5.0 [64-bit]
Type: Mac OS
Version: 13.5.0
Edition: None
Codename: None
Bitness: 64-bit
Architecture: Some("arm64") |
@srid I have added the condition to check whether the mac is configured using |
Alright, I'll take over from here. |
@srid Went through the refactored code, was very helpful. Thanks! |
Resolves #37
TODO:
os
fromSysInfo