Feature/set asr properties #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Изменения позволят использовать данный функционал JAICP: |
| fun setAsrProperties(properties: Map<String, String>) { | ||
| val propertiesJson = JsonObject(properties.toMutableMap().mapValues { entry -> JsonPrimitive(entry.value) }) | ||
| asrConfig = (executionContext.request as TelephonyBotRequest).asrConfig | ||
| when (checkNotNull(asrConfig?.type)) { |
There was a problem hiding this comment.
Это копипаст с JAICP?
Так-то просится ввернуть какую-нибудь chain of responsibility или иным образом инкапсулировать логику выбора конфига.
There was a problem hiding this comment.
Частично копипаст с JAICP, да. Вынести логику выбора конфига можно в другое место, но вроде особо некуда
| fun handle(properties: Map<String, String>, asrConfig: AsrConfig): AsrConfig { | ||
| val propertiesJson = JsonObject(properties.toMutableMap().mapValues { entry -> JsonPrimitive(entry.value) }) | ||
| return when (checkNotNull(asrConfig.type)) { | ||
| AsrConfig.AsrProviderType.SBER -> { |
There was a problem hiding this comment.
Главная идея - избавиться от этого when.
Условно нужно несколько моментов:
- Вынести конфигурацию списка хендлеров вне этого класса, т.е. будет что-то вида SetAsrPropertiesHandler(listOfActualHandlers)
- Сделать общий интерфейс хендлера с методами canHandle(...) и handle(...)
- Центральный хендлер (этот класс) делегирует canHandle() и handle() в лежащие внутри него хендлеры - кто первый ответит, что может захендлить, тот и хендлит.
There was a problem hiding this comment.
Реализовал как описано выше
ronrotem
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.