Disable step up and implement ranking #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now activators will only look on transitions either from the current context or from the root
morfeusys
requested changes
Oct 5, 2020
| ): Float { | ||
| val current = botContext.dialogContext.currentContext | ||
|
|
||
| val factor = when { |
There was a problem hiding this comment.
Just by trial-and-error. We have only three sets of states, so we can define constants for them instead of calculating some penalty at runtime
| @@ -0,0 +1,38 @@ | |||
| package com.justai.jaicf.model.activation.selection | |||
There was a problem hiding this comment.
Are you sure this interface and its implementations should be placed to model?
There was a problem hiding this comment.
I can move it to com.justai.jaicf.activator.selection, is it okay?
| * 2. The current state itself; | ||
| * 3. States available from the root of scenario. | ||
| */ | ||
| open class ContextRankingActivationSelector : ActivationSelector { |
There was a problem hiding this comment.
Why not to use this implementation as default selector instead of ContextFirstActivationSelector? Looks like it covers the context-first selector cases.
morfeusys
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now only the following transitions are available:
Implemented activation selection with two default implementations:
Closes #38