Check wp_get_attachment_image_src() return values in _get_image_attachment() #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hment() _get_image_attachment() could get called with an invalid $attachment_id parameter value (for example, when the get_scan_image() method extracts an image, the method will pass the complete match first (not just the ID). We need to make sure that we don't set an invalid image_args array in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_get_image_attachment()could get called with an invalid$attachment_idparameter value (for example, when theget_scan_image()method extracts an image, the method will pass the complete match first (not just the ID). We need to make sure that we don't set an invalid image_args array in this case.