Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete row small performance improvement #339

Conversation

splohmer
Copy link
Contributor

@splohmer splohmer commented Apr 3, 2024

there are deletions done on _sheetData but later on this is overwritten by _data, therefore these operations are useless.

there are deleteions done on _sheetData but later on this is overwritten by _data, therefore these operations are useless.
Copy link
Contributor

@FauconSpartiate FauconSpartiate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@FauconSpartiate FauconSpartiate merged commit 7aa1fc1 into justkawal:main Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants