Use HB messages to build and display a feature processing log #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this is a good start! I will need some time to review this (and the uharfbuzz counterpart), while also perhaps considering UI alternatives. |
|
Thanks Simon for getting the improved messages into HarfBuzz! In the meantime I think I better understand where this needs to be going in terms of UI, but I don't have immediate time to work on it. Hopefully later this summer. |
|
Please don't force-push: now I have no way of knowing what you changed since the last version of this PR. |
|
That was a mistake - I was trying to get current with upstream and thought I had put my tracing stuff on a feature branch. |
|
(Rebasing a PR is so much harder than it should be... I freak out every time I need to do it, and usually mess it up.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires harfbuzz/uharfbuzz#27 to be merged.