Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edits to iter_rings, to properly handle 'Z' and prep for other flags #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abrammer
Copy link

Made some improvements (hopefully) for using this with contour plots as I had the #40 issue then had funky lines due to the #51 "fix". #51 isn't the right solution, as has been mentioned before, while it creates plots it mainly creates broken outputs as the paths become offset.

Z should draw a line back to the start and yield the path not just append and keep going.
I've added in steps draw lines across the bezier curves which I've seen mentioned in issue, these should yield the correct linear path for now and add space for the bezier curve to be added in future.

Also added a contourf "test" which will reveal that #51 doesn't properly solve the problem.

fwiw, I got an indexing method working but it seemed like just running through the list was logically simpler given the variety of SVG codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant