Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format specifiers galore #20

Merged
merged 26 commits into from
Jul 6, 2023
Merged

Format specifiers galore #20

merged 26 commits into from
Jul 6, 2023

Conversation

jwosty
Copy link
Owner

@jwosty jwosty commented Jun 28, 2023 •
edited
Loading

jwosty added 26 commits June 26, 2023 13:10
@jwosty
Support .NET-style format specifiers and alignments
a70201b
@jwosty
Implement %x translation
f82a634
@jwosty
Translate width and precision specifiers
b22eac3
@jwosty
Assert rendered output using Serilog TextWriter sink
34ff4ff
@jwosty
Fix remaining test cases (and corresponding code when necessary)
e6c583c
@jwosty
Optimize with stringbuilder
4a68f5b
@jwosty
Fix JS tests
397cd3e
@jwosty
Change tests to assert against equivalent sprintf calls as well
957070c
@jwosty
Fix width to pad with spaces, not leading zeros as per MS docs
766f2bc
@jwosty
Implement zero-padding
0bd2ea0 
For example: `sprintf "%05f" 42.5` outputs `042.5`
@jwosty
Replace sharedTestCase with theory
d24d976
@jwosty
Parameterize test sets on log level, too
d31f10f
@jwosty
Compare log parameters instead of equivalent log call
be66363
@jwosty
Merge together now identical functions
8f83e83
@jwosty
Make Fable logf capable of stripping parameters with custom formatting
f2da5a4
@jwosty
Make .net-style formatters work under Fable
1302990
@jwosty
Refactor
022805f
@jwosty
Implement %e and %E
6d02818
@jwosty
Fix some corner cases around negative zeros and numbers close to it
b33de4b
@jwosty
Implement left-justify (-) flag
33ea64f
@jwosty
Implement space flag
05de2b9
@jwosty
Fix corner cases when combining + flag or space flag with 0 flag
3f647ef
@jwosty
Treat -0 flags as -
7cddfc3 
Left-justify with zero-padding is not possible using .NET format strings
@jwosty
Refactor
6f1397c
@jwosty
Fix some more missing corner cases
3a86d5c
@jwosty
Make fable tests pass by disabling workaround expectation value for f…
efd05d2 
…able
@jwosty jwosty merged commit 1855edf into master Jul 6, 2023
@jwosty jwosty mentioned this pull request Jul 8, 2023
Closed
7 tasks
@jwosty
Copy link
Owner Author

jwosty commented Jul 8, 2023

Printf-style format specifiers, are supported via translation to an equivalent .NET-style format strings when possible1. This ensures that the original object, as well as the formatted value, is preserved.

.NET-style format strings are supported in the same way as regular Log calls, by just passing them through.

Footnotes

  1. Left-justification combined with padding with 0 (for example "%0-10.1f is not possible to represent with a .NET format string. Behavior around printing -0.0 (negative zero float values) may not be as expected, due to both .NET and FSharp.Core bugs. ↩

@jwosty jwosty deleted the net-format-specifiers branch September 14, 2023 20:10
@jwosty jwosty restored the net-format-specifiers branch September 14, 2023 20:10
@jwosty jwosty deleted the net-format-specifiers branch October 27, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jwosty