Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument validation for allowedClockSkewSeconds #601

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Argument validation for allowedClockSkewSeconds #601

merged 2 commits into from
Jun 11, 2020

Conversation

lhazlewood
Copy link
Contributor

Ensured setting allowedClockSkewSeconds to be greater than (Long.MAX_VALUE / 1000) will throw an IllegalArgumentException.

Resolves #583

@lhazlewood
583: ensured setting allowedClockSkewSeconds to be greater than (Long…
dd045ae 
….MAX_VALUE / 1000) will throw an IllegalArgumentException.
@lhazlewood
583: ensured setting allowedClockSkewSeconds to be greater than (Long…
89ff864 
….MAX_VALUE / 1000) will throw an IllegalArgumentException.
@coveralls
Copy link

coveralls commented Jun 11, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 89ff864 on 583-seconds-overflow into 2b00ed1 on master.

@lhazlewood lhazlewood merged commit 72973f9 into master Jun 11, 2020
@lhazlewood lhazlewood deleted the 583-seconds-overflow branch June 11, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reject seconds values that would cause overflow
2 participants
@lhazlewood @coveralls