Return SalesforceResult when inserting data
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Jun 27, 2024
|
@0cv Thanks for drafting this! 🏆 I really like these suggestions, I think its a much needed improvement. What I'll end up doing is pull these changes into another branch and do some testing + any updates that might be needed. Once that's done, I'll ping you for another review. And then since this would technically be a breaking change I'll roll it out as version 2.0.0 🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #42
@k-capehart I know we discussed I'd not work on it, but I like this Go Sfdc module the most and well .. well I just built quickly what I needed. I'm not sure it's "production" ready so I put just a draft. So to explain a bit what I did, I've mostly reused the already existing
salesforceErrorwhich I renamed toSalesforceResult. And instead of formatting the error, which I don't think is a good idea, I'm returning this struct to the client. Then that's the client which can iterate through the result and analyze the errors accordingly (and get the created Sfdc ID). I've also plugged it intoInsertOne. Again it fits my needs, but it might need some polishing so for now I think it's more like an implementation idea.