update docs for GetAccessToken() and handle case where auth is nil #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Jun 27, 2024
| @@ -603,5 +603,8 @@ func (sf *Salesforce) GetJobResults(bulkJobId string) (BulkJobResults, error) { | |||
| } | |||
|
|
|||
| func (sf *Salesforce) GetAccessToken() string { | |||
| return sf.auth.AccessToken | |||
| if sf.auth != nil { | |||
There was a problem hiding this comment.
if sf.auth == nil {
return ""
}
return sf.auth.AccessTokenUsually it's written like this for clarity purpose
There was a problem hiding this comment.
@ccoVeille Actually, that's a good point. I'll make that update.
| @@ -93,6 +104,16 @@ if err != nil { | |||
| } | |||
| ``` | |||
|
|
|||
| ### GetAccessToken() | |||
|
|
|||
| `func (sf *Salesforce) GetAccessToken() string` | |||
There was a problem hiding this comment.
Suggested change
| `func (sf *Salesforce) GetAccessToken() string` | |
| ```go | |
| func (sf *Salesforce) GetAccessToken() string | |
| ``` |
This way the code will be formatted with Go syntax
There was a problem hiding this comment.
@ccoVeille I was specifically not formatting it that way for the headers here, but its a good thing to note. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.