Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cni and network-attachment-definition-client to support MTU #1250

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

SchSeba
Copy link
Contributor

@SchSeba SchSeba commented Mar 24, 2024

This is to support the new MTU field in cni network results

@SchSeba
Copy link
Contributor Author

SchSeba commented Mar 24, 2024

@coveralls
Copy link

Coverage Status

coverage: 62.778%. remained the same
when pulling 47a9d0a on SchSeba:support_mtu
into 0fd3fa7 on k8snetworkplumbingwg:master.

@dougbtv
Copy link
Member

dougbtv commented Mar 28, 2024

Thanks! Let's get it sorted in NPWG first and we'll move on with a review

@s1061123 s1061123 changed the title Bump cni and network-attachment-definition-client [WIP]Bump cni and network-attachment-definition-client Apr 1, 2024
@SchSeba SchSeba force-pushed the support_mtu branch 2 times, most recently from 212143b to 30d6aa0 Compare April 11, 2024 14:28
This is to support the new MTU field in cni network results

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@SchSeba SchSeba changed the title [WIP]Bump cni and network-attachment-definition-client Bump cni and network-attachment-definition-client to support MTU Apr 11, 2024
@SchSeba
Copy link
Contributor Author

SchSeba commented Apr 15, 2024

Hi @dougbtv @s1061123 can you please take a look at this PR now it's ready and we have all the relevant parts in the needed repos

Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the version bump for new net-attach-def client

@dougbtv dougbtv merged commit 9c2771b into k8snetworkplumbingwg:master Apr 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants