Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support override of the http.Transport in the http.Client - CASS-78 #730

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Nov 13, 2024

What this PR does:
Support override of the http.Transport in the http.Client we use for management client.

Reorder certain function parameters in the client.go to match best practices in Go and what we use elsewhere in the codebase

Which issue(s) this PR fixes:
Fixes #729

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner November 13, 2024 17:33
…management client. Also, reorder certain function parameters in the client.go to match best practises in Go and what we use elsewhere in the codebase
@burmanm burmanm force-pushed the add_custom_transport_support_to_client branch from 1c92722 to 9ca6201 Compare November 18, 2024 13:41
@adejanovski adejanovski changed the title Support override of the http.Transport in the http.Client Support override of the http.Transport in the http.Client - CASS-78 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for user provided http.Transport for ManagementClient
1 participant