General performance and readability optimisation pass #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhatdongdang
requested changes
Jun 28, 2024
| FILE* file = fopen(file_path, "rb"); | ||
|
|
||
| // Offset into correct sector of array | ||
| fread(tensors + ((file_num - 1) * TENSOR_SIZE), TENSOR_SIZE, sizeof(f32), file); |
There was a problem hiding this comment.
The current method for reading the input using a binary blob is causing issues with the CI tests. Please create a separate function specifically for reading the input using a binary blob. I recommend creating a corresponding target in the Makefile for this new method of reading input.
There was a problem hiding this comment.
I would rather change the CI, since we definitely aren't sticking with txt for long
There was a problem hiding this comment.
The CI works with any inputs located in the ./tensors folder. To ensure compatibility with the CI, we need to decide whether to convert all files in ./tensors to binary blobs.
nhatdongdang
requested changes
Jun 28, 2024
nhatdongdang
requested changes
Jun 29, 2024
|
Superseded by #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments, reductions in bloat, file reading and IO optimisations