Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve softmax perf 4x #24

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

rozukke
Copy link
Contributor

@rozukke rozukke commented Jul 3, 2024

Small fix that seems to improve perf for this function by about 4 to 5x.

@rozukke rozukke added enhancement New feature or request small-fix Small error or mistake labels Jul 3, 2024
@rozukke rozukke requested a review from nhatdongdang July 3, 2024 15:32
@rozukke rozukke self-assigned this Jul 3, 2024
Copy link
Collaborator

@nhatdongdang nhatdongdang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good shit

@nhatdongdang nhatdongdang merged commit 74dba0f into kachi-group:main Jul 4, 2024
2 checks passed
@rozukke rozukke deleted the fix/softmax-performance branch July 4, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request small-fix Small error or mistake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants