fix(graph): performance improvement on the transfers query (#2679)

kadena-community · Nov 21, 2024 · a8204ab · a8204ab
1 parent 54268f4
commit a8204ab
Show file tree

Hide file tree

Showing 18 changed files with 965 additions and 328 deletions.
diff --git a/.changeset/beige-nails-battle.md b/.changeset/beige-nails-battle.md
@@ -0,0 +1,8 @@
+---
+'@kadena/graph': major
+---
+
+BREAKING: removed totalCount on any `transfers` connection
+
+We removed this as it caused performance issues You can rely on hasNextPage and
+hasPreviousPage to determine if there are more pages
diff --git a/packages/apps/explorer/src/components/AccountTransfersTable/AccountTransfers.graph.ts b/packages/apps/explorer/src/components/AccountTransfersTable/AccountTransfers.graph.ts
@@ -12,7 +12,6 @@ export const accountTransfers: DocumentNode = gql`
     node(id: $id) {
       ... on FungibleAccount {
         transfers(first: $first, after: $after, last: $last, before: $before) {
-          totalCount
           pageInfo {
             endCursor
             hasNextPage

diff --git a/packages/apps/explorer/src/components/AccountTransfersTable/AccountTransfersTable.tsx b/packages/apps/explorer/src/components/AccountTransfersTable/AccountTransfersTable.tsx
@@ -76,7 +76,6 @@ export const AccountTransfersTable: FC<{ accountName: string }> = ({
       setPage={handlePageChange}
       pageSize={pageSize}
       pageInfo={innerData.node!.transfers.pageInfo}
-      totalCount={innerData.node!.transfers.totalCount}
       isLoading={isLoading}
       fields={[
         {

diff --git a/...es/apps/explorer/src/components/AccountTransfersTable/loadingDataAccountTransfersquery.ts b/...es/apps/explorer/src/components/AccountTransfersTable/loadingDataAccountTransfersquery.ts
@@ -11,7 +11,6 @@ export const loadingData: AccountTransfersQuery = {
         hasPreviousPage: false,
         startCursor: '',
       },
-      totalCount: 0,
       edges: Array(6).fill({
         node: {
           requestKey: '0',

diff --git a/packages/apps/graph/generated-schema.graphql b/packages/apps/graph/generated-schema.graphql
@@ -166,7 +166,6 @@ type FungibleAccountTransactionsConnectionEdge {
 type FungibleAccountTransfersConnection {
   edges: [FungibleAccountTransfersConnectionEdge!]!
   pageInfo: PageInfo!
-  totalCount: Int!
 }
 
 type FungibleAccountTransfersConnectionEdge {

diff --git a/packages/apps/graph/package.json b/packages/apps/graph/package.json
@@ -19,7 +19,7 @@
   "scripts": {
     "build": "pnpm run pactjs:generate:contracts && pnpm prisma:generate && tsc",
     "deploy:marmalade": "ts-node -T src/devnet/deployment/index.ts deploy:marmalade",
-    "devnet": "docker volume create kadena_devnet; docker run --rm -it -p 8080:8080 -p 5432:5432 -p 9999:9999 -p 1789:1789 -v kadena_devnet:/data -v ./cwd-extra-migrations:/cwd-extra-migrations:ro --name devnet kadena/devnet",
+    "devnet": "docker volume create kadena_devnet_crashnet; docker run --rm -it -p 8080:8080 -p 5432:5432 -p 9999:9999 -p 1789:1789 -p 1848:1848 -v kadena_devnet_crashnet:/data -v ./cwd-extra-migrations:/cwd-extra-migrations:ro --name devnet kadena/devnet:crashnet-arm64",
     "devnet:update": "docker pull kadena/devnet",
     "format": "pnpm run --sequential /^format:.*/",
     "format:lint": "pnpm run lint:src --fix",
@@ -41,7 +41,7 @@
     "simulate:coin": "ts-node -T src/devnet/simulation/index.ts simulate:coin",
     "simulate:flood": "ts-node -T src/devnet/simulation/index.ts simulate:flood",
     "simulate:marmalade": "ts-node -T src/devnet/simulation/index.ts simulate:marmalade",
-    "start": "npx ts-node-dev --respawn --no-notify --exit-child src/index.ts",
+    "start": "npx ts-node-dev -T --respawn --no-notify --exit-child src/index.ts",
     "start:generate": "pnpm build && npx ts-node-dev --respawn --no-notify --exit-child src/index.ts",
     "test": "echo \"no test specified\"",
     "testing": "ts-node -T src/devnet/simulation/index.ts test",
@@ -92,6 +92,7 @@
     "@rushstack/eslint-config": "~3.6.9",
     "@types/debug": "~4.1.12",
     "@types/js-yaml": "4.0.9",
+    "@types/lodash": "^4.17.13",
     "@types/node": "^20.12.7",
     "@types/pg": "~8.11.5",
     "@types/seedrandom": "~3.0.8",

diff --git a/packages/apps/graph/prisma/schema.prisma b/packages/apps/graph/prisma/schema.prisma
@@ -1,6 +1,6 @@
 generator client {
   provider        = "prisma-client-js"
-  previewFeatures = ["views"]
+  previewFeatures = ["views", "relationJoins"]
 }
 
 generator pothos {