Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Ladle (over Storybook) in react-ui with 2 components #1114

Closed
wants to merge 9 commits into from

Conversation

webpro
Copy link
Contributor

@webpro webpro commented Oct 24, 2023

Performance and maintenance with Storybook isn't great. This PR is a starting point to discuss a potential move to e.g. Ladle: https://ladle.dev

Please try it to feel the difference :)

pnpm -F @kadena/react-ui run storybook       # or..
pnpm storybook                               # from packages/libs/react-ui

(I didn't rename the scripts yet so this might look odd indeed.)

Use the built-in dark mode and the look & feel already comes pretty close to Storybook.

Most add-ons we're using are there and there's a solution for visual regression testing too.

The migration shouldn't be too cumbersome, I guess a day or two?

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

⚠️ No Changeset found

Latest commit: 6ef3b82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 1:43pm
docs-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 1:43pm
react-ui ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 1:43pm
tools ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 1:43pm

@Ghislain89
Copy link
Contributor

/snapshots

@Ghislain89 Ghislain89 closed this Dec 6, 2023
@Ghislain89 Ghislain89 deleted the try/ladle branch December 6, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants