Migrate from MSW 1.3.2 → 2.0.0 #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
🦋 Changeset detectedLatest commit: dde0f42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
webpro
requested review from
eileenmguo,
sstraatemans and
timoheddes
as code owners
webpro
force-pushed
the
chore/migrate-msw2
branch
from
6285ddb to
a7aee63
Compare
webpro
force-pushed
the
chore/migrate-msw2
branch
from
a7aee63 to
dde0f42
Compare
alber70g
approved these changes
Oct 26, 2023
Ghislain89
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coincidentally, MSW v2 was released the day we've merged all the tests to Vitest + MSW v1.
So here is part 2, v2. More details
The other changes were unfortunately necessary due to some dependency conflicts. My advice here: get rid of Webpack and Babel whenever possible. Switch to SWC in Next.js (not sure why Nxt.js keeps holding on to building with Webpack).