Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kadena-cli): account commands #1253

Merged
merged 6 commits into from
Dec 20, 2023

Conversation

jessevanmuijden
Copy link
Contributor

Depends on support for any fungible in @kadena/client-utils. #1245

Copy link

changeset-bot bot commented Nov 23, 2023

🦋 Changeset detected

Latest commit: c4064ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kadena/kadena-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2023 1:01pm
docs-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2023 1:01pm
proof-of-us ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2023 1:01pm
react-ui ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2023 1:01pm
tools ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2023 1:01pm

Copy link
Contributor

@nillo nillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate the changes to libs/client-utils from this PR

@jessevanmuijden jessevanmuijden force-pushed the feat/kadena-cli/account branch 2 times, most recently from 2a8a2ac to 1609c03 Compare December 6, 2023 14:59
@jessevanmuijden jessevanmuijden marked this pull request as ready for review December 6, 2023 15:01
Copy link
Contributor

@nillo nillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -47,7 +47,7 @@
"@kadena/pactjs-generator": "workspace:*",
"@scure/bip39": "^1.2.1",
"cardano-crypto.js": "https://github.com/kadena-io/cardano-crypto.js.git#jam@chainweaver-keygen",
"chalk": "^4.1.2",
"chalk": "^5.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets make sure these changes to the packages don't break anything ( yes we should be up to date, but donno if there are breaking changes )

@jessevanmuijden jessevanmuijden merged commit ebfd979 into feat/full-kda-cli Dec 20, 2023
10 of 12 checks passed
@jessevanmuijden jessevanmuijden deleted the feat/kadena-cli/account branch December 20, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants